naive-zhang commented on code in PR #6815:
URL: https://github.com/apache/kyuubi/pull/6815#discussion_r1848595531
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiBaseResultSet.java:
##########
@@ -338,6 +338,10 @@ private Object evaluate(TTypeId columnType, Object value) {
if (value instanceof String) {
return ((String) value).getBytes();
}
+ case INT_TYPE:
+ if (value instanceof String) {
+ return Integer.valueOf((String) value);
Review Comment:
Thank you for your review, because in case of NUMBER(x,0) refering to
Integer in Oracle, OJDBC returns it as java.sql.Types.NUMERIC. In this case, I
implement `toTTypeDesc` method of `OracleSchemaHelper` to make sure
`NUMBER(x,0)` treated as Integer in `resultSet.getMetaData`, but in `evaluate`
method of `KyuubiBaseResultSet`, it treated `java.sql.Types.NUMERIC` as
decimal, which is instance of String. Is my implementation OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
