pan3793 commented on code in PR #6829:
URL: https://github.com/apache/kyuubi/pull/6829#discussion_r1866092096
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala:
##########
@@ -420,15 +421,24 @@ private[v1] class BatchesResource extends
ApiRequestContext with Logging {
s"The valid batch state can be one of the following:
${VALID_BATCH_STATES.mkString(",")}")
}
+ val createTimeFilter =
+ math.max(createTime, metadataSearchWindow.map(System.currentTimeMillis()
- _).getOrElse(0L))
val filter = MetadataFilter(
sessionType = SessionType.BATCH,
engineType = batchType,
username = batchUser,
state = batchState,
requestName = batchName,
- createTime = createTime,
+ createTime = createTimeFilter,
endTime = endTime)
Review Comment:
not related to this PR, but `createTime` and `endTime` are confusing, should
be `minCreateTime` and `maxEndTime`, and say if they are inclusive or exclusive
in the comments, with an explanation for specific values
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala:
##########
@@ -257,14 +257,15 @@ class JDBCMetadataStore(conf: KyuubiConf) extends
MetadataStore with Logging {
filter: MetadataFilter,
from: Int,
size: Int,
- desc: Boolean = false): Seq[Metadata] = {
+ desc: Boolean = false,
+ orderByKeyId: Boolean = true): Seq[Metadata] = {
val queryBuilder = new StringBuilder
val params = ListBuffer[Any]()
queryBuilder.append("SELECT ")
queryBuilder.append(METADATA_COLUMNS)
queryBuilder.append(s" FROM $METADATA_TABLE")
queryBuilder.append(s" ${assembleWhereClause(filter, params)}")
- queryBuilder.append(" ORDER BY key_id ")
+ queryBuilder.append(" ORDER BY ").append(if (orderByKeyId) "key_id " else
"create_time ")
Review Comment:
have you tried without `ORDER BY` clause? if the result ordering is stable
(for example, ordered by pk), it might be the fastest approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
