turboFei commented on code in PR #6863:
URL: https://github.com/apache/kyuubi/pull/6863#discussion_r1897133058


##########
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/PrometheusReporterService.scala:
##########
@@ -100,4 +100,90 @@ class PrometheusReporterService(registry: MetricRegistry)
       }
     }
   }
+
+  private def createPrometheusServlet(): HttpServlet = {
+    new HttpServlet {
+      override def doGet(request: HttpServletRequest, response: 
HttpServletResponse): Unit = {
+        try {
+          response.setContentType("text/plain;charset=utf-8")
+          response.setStatus(HttpServletResponse.SC_OK)
+          response.getWriter.print(getMetricsSnapshot())
+        } catch {
+          case e: IllegalArgumentException =>
+            response.sendError(HttpServletResponse.SC_BAD_REQUEST, 
e.getMessage)
+          case e: Exception =>
+            warn(s"GET ${request.getRequestURI} failed: $e", e)
+            throw e
+        }
+      }
+      // ensure TRACE is not supported
+      override protected def doTrace(req: HttpServletRequest, res: 
HttpServletResponse): Unit = {
+        res.sendError(HttpServletResponse.SC_METHOD_NOT_ALLOWED)
+      }
+    }
+  }
+
+  private def getMetricsSnapshot(): String = {
+    import scala.collection.JavaConverters._
+
+    val gaugesLabel = s"""{type="gauges",$instanceLabel}"""
+    val countersLabel = s"""{type="counters",$instanceLabel}"""
+    val metersLabel = countersLabel
+    val histogramslabels = s"""{type="histograms",$instanceLabel}"""
+    val timersLabels = s"""{type="timers",$instanceLabel}"""
+
+    val sb = new StringBuilder()
+    registry.getGauges.asScala.foreach { case (k, v) =>
+      if (!v.getValue.isInstanceOf[String]) {
+        sb.append(s"${normalizeKey(k)}$gaugesLabel ${v.getValue}\n")
+      }
+    }
+    registry.getCounters.asScala.foreach { case (k, v) =>
+      sb.append(s"${normalizeKey(k)}$countersLabel ${v.getCount}\n")
+    }
+    registry.getHistograms.asScala.foreach { case (k, h) =>
+      val snapshot = h.getSnapshot
+      val prefix = normalizeKey(k)
+      sb.append(s"${prefix}_count$histogramslabels ${h.getCount}\n")
+      sb.append(
+        s"${prefix}{quantile=\"0.5\",type=\"histograms\",$instanceLabel} 
${snapshot.getMedian}\n")
+      
sb.append(s"${prefix}{quantile=\"0.75\",type=\"histograms\",$instanceLabel} 
${snapshot.get75thPercentile()}\n")
+      
sb.append(s"${prefix}{quantile=\"0.95\",type=\"histograms\",$instanceLabel} 
${snapshot.get95thPercentile()}\n")
+      
sb.append(s"${prefix}{quantile=\"0.98\",type=\"histograms\",$instanceLabel} 
${snapshot.get98thPercentile()}\n")
+      
sb.append(s"${prefix}{quantile=\"0.99\",type=\"histograms\",$instanceLabel} 
${snapshot.get99thPercentile()}\n")
+      
sb.append(s"${prefix}{quantile=\"0.999\",type=\"histograms\",$instanceLabel} 
${snapshot.get999thPercentile()}\n")
+    }
+    registry.getMeters.entrySet.iterator.asScala.foreach { kv =>
+      val prefix = normalizeKey(kv.getKey)
+      val meter = kv.getValue
+      sb.append(s"${prefix}$metersLabel ${meter.getCount}\n")
+      sb.append(s"${prefix}_MeanRate$metersLabel ${meter.getMeanRate}\n")

Review Comment:
   Meter example before
   ```
   # HELP kyuubi_operation_state_initialized_total Generated from Dropwizard 
metric import (metric=kyuubi.operation.state.initialized, 
type=com.codahale.metrics.Meter)
   # TYPE kyuubi_operation_state_initialized_total counter
   kyuubi_operation_state_initialized_total 1371702.0
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to