turboFei commented on code in PR #6867:
URL: https://github.com/apache/kyuubi/pull/6867#discussion_r1897527850
##########
grafana/dashboard-template.json:
##########
@@ -684,27 +718,27 @@
{
"datasource": "${DS_PROMETHEUS}",
"editorMode": "code",
- "expr":
"kyuubi_memory_usage_pools_PS_Eden_Space_used{instance=~\"$instance\",job=~\"$job\"}",
+ "expr":
"kyuubi_memory_usage_pools_PS_Eden_Space_used{instance=~\"$instance\",$baseFilter}",
"hide": false,
- "legendFormat": "Eden Space Used",
+ "legendFormat": "${baseLegend} Eden Space Used",
"range": true,
"refId": "B"
},
{
"datasource": "${DS_PROMETHEUS}",
"editorMode": "code",
- "expr": "sum(kyuubi_memory_usage_pools_Par_Eden_Space_committed)",
+ "expr":
"kyuubi_memory_usage_pools_Par_Eden_Space_committed{instance=~\"$instance\",$baseFilter}",
"hide": false,
- "legendFormat": "Eden Space Committed",
+ "legendFormat": "${baseLegend} Eden Space Committed",
"range": true,
"refId": "A"
},
{
"datasource": "${DS_PROMETHEUS}",
"editorMode": "code",
- "expr": "sum(kyuubi_memory_usage_pools_Par_Eden_Space_max)",
Review Comment:
not sure whether the `sum` is necessary, but I think we can remove such kind
of metrics.
Because seems it does not exists for my kyuubi server + JDK17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
