turboFei commented on code in PR #6866:
URL: https://github.com/apache/kyuubi/pull/6866#discussion_r1897605260
##########
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/MetricsConstants.scala:
##########
@@ -37,6 +37,8 @@ object MetricsConstants {
final private val THRIFT_BINARY_CONN = KYUUBI + "thrift.binary.connection."
final private val REST_CONN = KYUUBI + "rest.connection."
+ final val SSL_CERT_EXPIRATION = KYUUBI + "ssl.cert.expiration"
Review Comment:
Currently, the keystore is not used for RESTful yet.
We use the certificate of Loadbalancer for http SSL instead of maintain the
keystore for every kyuubi instance.
##########
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/MetricsConstants.scala:
##########
@@ -37,6 +37,8 @@ object MetricsConstants {
final private val THRIFT_BINARY_CONN = KYUUBI + "thrift.binary.connection."
final private val REST_CONN = KYUUBI + "rest.connection."
+ final val SSL_CERT_EXPIRATION = KYUUBI + "ssl.cert.expiration"
Review Comment:
Currently, the keystore is not used for RESTful yet.
In ebay, we use the certificate of Loadbalancer for http SSL instead of
maintain the keystore for every kyuubi instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
