pan3793 commented on code in PR #7011:
URL: https://github.com/apache/kyuubi/pull/7011#discussion_r2026416589
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -167,18 +167,21 @@ class KyuubiSessionImpl(
warn(s"Error on de-registering engine [${engine.engineSpace}
$host:$port]", e)
}
+ var engineClient: KyuubiSyncThriftClient = null
try {
val passwd =
if (sessionManager.getConf.get(ENGINE_SECURITY_ENABLED)) {
InternalSecurityAccessor.get().issueToken()
} else {
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host,
port, sessionConf)
+ engineClient =
+ KyuubiSyncThriftClient.createClient(user, passwd, host, port,
sessionConf)
Review Comment:
I checked the code, the `socket.open` actually happens in this method, do
you mean you have observed that `socket.open` succeeded but `openSession`
failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
