pan3793 commented on PR #7121: URL: https://github.com/apache/kyuubi/pull/7121#issuecomment-3021821749
@wangzhigang1999 thanks for making this change, the idea and testing result looks promising. I understand that you are trying to be careful with existing code when adding a new implementation. But for this case, it looks like too overkill to me. I think the new approach is quite solid and has really low risk, can we simply replace the existing one, to avoid introducing unnecessary complexity? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
