pan3793 commented on code in PR #7123:
URL: https://github.com/apache/kyuubi/pull/7123#discussion_r2191867275
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTable.scala:
##########
@@ -77,7 +94,11 @@ case class HiveTable(
}
override def newScanBuilder(options: CaseInsensitiveStringMap): ScanBuilder
= {
- HiveScanBuilder(sparkSession, fileIndex, dataSchema, catalogTable)
+ convertedProvider match {
+ case Some("ORC") if
sparkSession.sessionState.conf.getConf(READ_CONVERT_METASTORE_ORC) =>
Review Comment:
this requires more work and is more invasive compared to the current
approach, let's try this simple way first, and the extended rule approach can
be evaluated later
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTable.scala:
##########
@@ -77,7 +94,11 @@ case class HiveTable(
}
override def newScanBuilder(options: CaseInsensitiveStringMap): ScanBuilder
= {
- HiveScanBuilder(sparkSession, fileIndex, dataSchema, catalogTable)
+ convertedProvider match {
+ case Some("ORC") if
sparkSession.sessionState.conf.getConf(READ_CONVERT_METASTORE_ORC) =>
Review Comment:
that requires more work and is more invasive compared to the current
approach, let's try this simple way first, and the extended rule approach can
be evaluated later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
