turboFei commented on code in PR #7132:
URL: https://github.com/apache/kyuubi/pull/7132#discussion_r2199603860
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -79,7 +79,23 @@ class BatchJobSubmission(
def appStartTime: Long = _appStartTime
def appStarted: Boolean = _appStartTime > 0
- private lazy val _submitTime = if (appStarted) _appStartTime else
System.currentTimeMillis
+ private lazy val _submitTime = System.currentTimeMillis
+
+ /**
+ * If the application has been submitted (applicationId is not empty),
return the application
+ * start time. Otherwise, if the builder process does not wait for the
engine completion and
+ * the process is not terminated, return the current time as the submit time
to prevent
+ * application failed within NOT_FOUND state due to the process duration
exceeds the engine submit
+ * timeout. Otherwise, return the time that start to run the batch job
submission operation.
+ * @return the time that start to count the application submit timeout.
+ */
+ private def submitTime: Long = if (appStarted) {
Review Comment:
updated the method description @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
