pan3793 opened a new pull request, #64:
URL: https://github.com/apache/kyuubi-shaded/pull/64
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in
https://github.com/apache/kyuubi/issues, add '[KYUUBI-SHADED #XXXX]' in your PR
title, e.g., '[KYUUBI-SHADED #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][KYUUBI-SHADED #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
To allow Kyuubi to compile with `-release:8` in JDK 9+, we must cut out
direct access `sun.misc.Signal`, this PR achieves it by creating wrapper
classes of `sun.misc.Signal` and `sun.misc.SignalHandler` in the Kyuubi Shaded
project.
Currently, both Kyuubi and Kyuubi Shaded use Java 8 for release. After this
change, Kyuubi can use any of Java 8+ to compile with `-release:8` while still
ensuring compatibility with Java 8.
### _How was this patch tested?_
Have done a PoC - modify Kyuubi code to use the wrapper Signal classes, and
compile with JDK 21, run on JDK 8, everything works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
