pan3793 commented on code in PR #7171:
URL: https://github.com/apache/kyuubi/pull/7171#discussion_r2278348812
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala:
##########
@@ -151,6 +151,12 @@ class EtcdDiscoveryClient(conf: KyuubiConf) extends
DiscoveryClient {
kvClient.get(ByteSequence.from(path.getBytes())).get().getKvs.isEmpty
}
+ override def pathNonExists(path: String, isPrefix: Boolean): Boolean = {
+ kvClient.get(
+ ByteSequence.from(path.getBytes()),
+ GetOption.newBuilder().isPrefix(isPrefix).build()).get().getKvs.isEmpty
Review Comment:
what will happen if we always set isPrefix to true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
