yabola commented on code in PR #7184:
URL: https://github.com/apache/kyuubi/pull/7184#discussion_r2329327936
##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/helper/SparkSQLLineageParseHelper.scala:
##########
@@ -53,18 +54,27 @@ trait LineageParser {
type AttributeMap[A] = ListMap[Attribute, A]
def parse(plan: LogicalPlan): Lineage = {
- val columnsLineage =
- extractColumnsLineage(plan, ListMap[Attribute,
AttributeSet]()).toList.collect {
- case (k, attrs) =>
- k.name -> attrs.map(attr => (attr.qualifier :+
attr.name).mkString(".")).toSet
+ val inputTablesByPlan = mutable.HashSet[String]()
+ val columnsLineage = extractColumnsLineage(
+ plan,
+ ListMap[Attribute, AttributeSet](),
+ inputTablesByPlan).toList.collect {
+ case (k, attrs) =>
+ k.name -> attrs.map(attr => (attr.qualifier :+
attr.name).mkString(".")).toSet
+ }
+ val (inputTablesByColumn, outputTables) = columnsLineage
+ .foldLeft((List[String](), List[String]())) {
+ case ((inputs, outputs), (out, in)) =>
+ val x = (inputs ++
in.map(_.split('.').init.mkString("."))).filter(_.nonEmpty)
+ val y = outputs ++
List(out.split('.').init.mkString(".")).filter(_.nonEmpty)
+ (x, y)
}
- val (inputTables, outputTables) = columnsLineage.foldLeft((List[String](),
List[String]())) {
- case ((inputs, outputs), (out, in)) =>
- val x = (inputs ++
in.map(_.split('.').init.mkString("."))).filter(_.nonEmpty)
- val y = outputs ++
List(out.split('.').init.mkString(".")).filter(_.nonEmpty)
- (x, y)
+ if
(SparkContextHelper.getConf(LineageConf.LEGACY_COLLECT_INPUT_TABLES_ENABLED)) {
+ Lineage(inputTablesByColumn.distinct, outputTables.distinct,
columnsLineage)
+ } else {
+ val filteredInputTables = inputTablesByPlan -- outputTables.distinct
Review Comment:
Sorry, my fault. I reconfirmed that databricks will include `a` as
upstream table , but merge into will not (although the source table is also
scanned ). I'm confused about this behavior. This may be related to execution
plan parsing. For tables that support row-level updates (datasourcev2 table
which implement interface `SupportsRowLevelOperations` , iceberg etc.) , the
plan can be parsed to the source table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
