wForget commented on code in PR #7198:
URL: https://github.com/apache/kyuubi/pull/7198#discussion_r2342760463
##########
externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/spark/kyuubi/SparkSQLEngineDeregisterSuite.scala:
##########
@@ -61,14 +60,8 @@ abstract class SparkSQLEngineDeregisterSuite
class SparkSQLEngineDeregisterExceptionSuite extends
SparkSQLEngineDeregisterSuite {
override def withKyuubiConf: Map[String, String] = {
- super.withKyuubiConf ++ Map(ENGINE_DEREGISTER_EXCEPTION_CLASSES.key -> {
- if (SPARK_ENGINE_RUNTIME_VERSION >= "3.3") {
- // see https://issues.apache.org/jira/browse/SPARK-35958
- "org.apache.spark.SparkArithmeticException"
- } else {
- classOf[ArithmeticException].getCanonicalName
- }
- })
+ super.withKyuubiConf ++
+ Map(ENGINE_DEREGISTER_EXCEPTION_CLASSES.key ->
"org.apache.spark.SparkArithmeticException")
Review Comment:
Can it be replaced with `classOf[SparkArithmeticException].getCanonicalName
` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
