Copilot commented on code in PR #7227:
URL: https://github.com/apache/kyuubi/pull/7227#discussion_r2461836776
##########
integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala:
##########
@@ -254,4 +254,56 @@ class KyuubiOperationKubernetesClusterClusterModeSuite
sessionHandle.identifier.toString)
assert(!failKillResponse._1)
}
+ test(
+ "If spark batch reach timeout, it should have associated Kyuubi
Application Operation be " +
Review Comment:
Grammatical error in test description. Should be 'reaches timeout' instead
of 'reach timeout', and 'should have the associated' instead of 'should have
associated'.
```suggestion
"If spark batch reaches timeout, it should have the associated Kyuubi
Application Operation be " +
```
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -322,7 +322,27 @@ class KubernetesApplicationOperation extends
ApplicationOperation with Logging {
if (elapsedTime > submitTimeout) {
error(s"Can't find target driver pod by ${toLabel(tag)}, " +
s"elapsed time: ${elapsedTime}ms exceeds ${submitTimeout}ms.")
- ApplicationInfo.NOT_FOUND
+ val errorMsg =
+ s"Driver pod not found for job with kyuubi-unique-tag: $tag
after $elapsedTime ms " +
+ s"(submit-timeout: $submitTimeout ms)"
+ /* update the metadata store => have current op
+ that handles given spark app as timed out
+ & associated spark-sql driver engine as
+ not found... test if this will prevent future polling */
Review Comment:
[nitpick] This multi-line comment uses informal language and incomplete
phrasing ('test if this will prevent future polling'). Consider rewriting as:
'Update the metadata store to mark this operation as timed out and the Spark
driver engine as not found. This prevents the restarted Kyuubi server from
repeatedly polling for this batch job's status.'
```suggestion
/* Update the metadata store to mark this operation as timed out
and the Spark driver engine as not found.
* This prevents the restarted Kyuubi server from repeatedly
polling for this batch job's status.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
