pan3793 commented on code in PR #7232:
URL: https://github.com/apache/kyuubi/pull/7232#discussion_r2464487474
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/ApiUtils.scala:
##########
@@ -136,6 +137,22 @@ object ApiUtils extends Logging {
"Running")
}
+ def serverEvent(serverEvent: KyuubiServerInfoEvent): KyuubiServerEvent = {
+ if (serverEvent == null) return new KyuubiServerEvent()
+ new KyuubiServerEvent(
+ serverEvent.serverName,
+ serverEvent.startTime,
+ serverEvent.eventTime,
+ serverEvent.state,
+ serverEvent.serverIP,
+ serverEvent.serverConf.asJava,
+ serverEvent.serverEnv.asJava,
Review Comment:
for a security perspective, we should redact sensitive info by default,
maybe we can have a server side config to control the behavior, the candidate
value can be `ORIGINAL`, `REDACTED`, `NONE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
