JoonPark1 commented on PR #7227:
URL: https://github.com/apache/kyuubi/pull/7227#issuecomment-3453001547

   Hey @turboFei. I'm reconsidering moving my metadata-updating logic directly 
into the BatchJobSubmission:updateBatchMetadata method like you suggested... 
Does this seem like a good logic to set the appState appropriate as TIMED_OUT 
(which is appropriate given the situation). 
   ```
   val curTime = System.currentTimeMillis();
       val submitTime = submitTime(); 
       val diff = curTime - submitTime 
       if(diff > KyuubiConf.ENGINE_SUBMIT_TIMEOUT && 
state.toString.equals("PENDING")){
         _applicationInfo = Some(ApplicationInfo.NOT_FOUND)
         state = OperationState.TIMEOUT
       }
   ```
   Let me know if you think this refactoring done directly within the 
updateBatchMetadata method is more appropriate. This should update batch 
metadata store the same way as having the effect done at 
KyuubiApplicationOperation level. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to