ruanwenjun commented on code in PR #7227:
URL: https://github.com/apache/kyuubi/pull/7227#discussion_r2540193935
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -181,36 +181,51 @@ class KyuubiRestFrontendService(override val serverable:
Serverable)
@VisibleForTesting
private[kyuubi] def recoverBatchSessions(): Unit =
withBatchRecoveryLockRequired {
val recoveryNumThreads = conf.get(METADATA_RECOVERY_THREADS)
+ val recoveryBatchSize: Int = conf.get(BATCH_SESSIONS_RECOVERY_SIZE)
Review Comment:
If we want greater concurrency, we should be able to increase this value.
My concern is that we've added an extra configuration parameter, but this
parameter is actually only used to control the batch size for queries from the
database. Query results are also subject to `recoveryNumThreads ` here.
If we use recoveryNumThreads as the batchSize, it would be simpler to use,
we only need to consider concurrency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
