pan3793 commented on code in PR #7294:
URL: https://github.com/apache/kyuubi/pull/7294#discussion_r2659276823
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -180,6 +180,11 @@ class KyuubiSessionImpl(
_engineSessionHandle =
engineClient.openSession(protocol, user, passwd,
openEngineSessionConf)
_client = engineClient
+ // Since the _client might be null when we close session
+ // so we need to check isClosed here
Review Comment:
> The `_client` can be null here and won't throw NPE at L181 because it's
null due to not having been assigned a value yet.
I didn't get your point, the previous L182 assigns `_client = engineClient`,
which means either NPE will be thrown, or `_engine` won't be null here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
