yabola commented on code in PR #7181:
URL: https://github.com/apache/kyuubi/pull/7181#discussion_r2675583757
##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/helper/SparkSQLLineageParseHelper.scala:
##########
@@ -128,15 +128,17 @@ trait LineageParser {
inputTablesByPlan: mutable.HashSet[String]): AttributeMap[AttributeSet]
= {
val exps = named.map {
case exp: Alias =>
+ val subqueryPlans = getExpressionSubqueryPlans(exp.child)
val references =
- if (exp.references.nonEmpty) exp.references
- else {
- val attrRefs = getExpressionSubqueryPlans(exp.child)
+ if (exp.references.isEmpty || subqueryPlans.nonEmpty) {
Review Comment:
Yes, this is redundant code, I deleted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
