Copilot commented on code in PR #7313:
URL: https://github.com/apache/kyuubi/pull/7313#discussion_r2736240379
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -660,7 +660,9 @@ object KubernetesApplicationOperation extends Logging {
case None => podAppState
}
val applicationError = {
- if (ApplicationState.isFailed(applicationState, supportPersistedAppState
= true)) {
+ if (ApplicationState.isFailed(
+ applicationState,
+ supportPersistedAppState = true) || ApplicationState.PENDING ==
applicationState) {
Review Comment:
The comparison order `ApplicationState.PENDING == applicationState` is
inconsistent with the codebase convention. Throughout the codebase, comparisons
consistently use the pattern `state == ApplicationState.XXX` (variable on left,
constant on right). This should be changed to `applicationState ==
ApplicationState.PENDING` for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
