pan3793 commented on code in PR #7318:
URL: https://github.com/apache/kyuubi/pull/7318#discussion_r2745418390
##########
dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/TPCDS_2_4_Queries.scala:
##########
@@ -132,18 +128,8 @@ trait TPCDS_2_4_Queries extends Benchmark {
"q99",
"ss_max")
- val tpcds2_4Queries: Seq[Query] = queryNames.map { queryName =>
- val in =
getClass.getClassLoader.getResourceAsStream(s"tpcds_2_4/$queryName.sql")
- val queryContent: String = Source.fromInputStream(in)(Codec.UTF8).mkString
- in.close()
-
- Query(
- queryName + "-v2.4",
- queryContent,
- description = "TPC-DS 2.4 Query",
- executionMode = CollectResults)
- }
+ val tpcds2_4Queries: Seq[Query]
- val tpcds2_4QueriesMap: Map[String, Query] =
+ lazy val tpcds2_4QueriesMap: Map[String, Query] =
Review Comment:
what's the benefit, and where is the var used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
