[
https://issues.apache.org/jira/browse/LIBCLOUD-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272433#comment-14272433
]
ASF GitHub Bot commented on LIBCLOUD-650:
-----------------------------------------
GitHub user Itxaka opened a pull request:
https://github.com/apache/libcloud/pull/431
LIBCLOUD-650: ex_create_multi_value_record only returns one record
Fixes that bug and also adds tests for that function.
Bug discovery and solution by @jvrplmlmn
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Itxaka/libcloud LIBCLOUD-650
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #431
----
commit 7eaaedd0c29270b8875381be64d772d6a60a5434
Author: Itxaka Serrano <itxakaserr...@gmail.com>
Date: 2015-01-10T10:23:34Z
Fixes LIBCLOUD-650: ex_create_multi_value_record only returns one record
(route53 driver), adds tests for that function.
----
> Route53 ex_create_multi_value_record only returns one record
> ------------------------------------------------------------
>
> Key: LIBCLOUD-650
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-650
> Project: Libcloud
> Issue Type: Bug
> Components: DNS
> Reporter: Itxaka Serrano
> Labels: bug, dns, newbie, test
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Calling ex_create_multi_value_record on the Route53 driver only returns one
> Record object but it should return several values.
> On libcloud.dns.driver.route53.py lines 270-276:
> {code}
> records = []
> for value in values:
> record = Record(id=id, name=name, type=type, data=value,
> zone=zone,
> driver=self, extra=extra)
> records.append(record)
> return record
> {code}
> It should return records instead.
> Creating a PR for this on github and adding tests to check for correct return
> values as well.
> This issue was discovered by http://github.com/jvrplmlmn
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
