GitHub user MrBasset opened a pull request:
https://github.com/apache/libcloud/pull/578
Proxy_url & connection object fixes
I have a use case that requires explicitly setting the proxy_url for
accessing a vCloud API (as opposed to the default environment proxy). I noticed
that the proxy_url was not being passed to the base Connection class by the
base NodeDriver. I fixed this by adding the proxy_url into the constructor call
where the connection class is created.
Also, within the vCouldNodeDriver a new connection class we being created
with
no custom variables rather than re-using the existing connection class. Any
custom values, such as the proxy_url, were not being passed to this new
instance. By swapping to the self.connection class these variables are set.
I could not find any unit tests that would demonstrate this issue (I would
assume that they would be integration tests anyway). So apologies that this fix
does not have supporting tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MrBasset/libcloud trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit c92472fa42eef41ffd8bd7afef9b5b841099bf93
Author: MrBasset <[email protected]>
Date: 2015-09-11T18:22:58Z
Proxy_url & connection object fixes
The proxy_url was not being passed to the base Connection class by the
base NodeDriver.
Within the vCouldNodeDriver a new connection class we being created with
no custom variables rather than re-using the existing connection class.
Signed-off-by: MrBasset <[email protected]>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
