GitHub user relaxdiego opened a pull request:
https://github.com/apache/libcloud/pull/814
Fix dimensiondata lb port
### Description
The documentation for the Dimension Data Cloud REST API v2.2-20160222
states that a load balancer port can be an integer in the range of 1-65535 and,
if not supplied, will be taken to mean 'Any Port'
This change fixes the libcloud driver to conform to the docs.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/relaxdiego/libcloud fix_dimensiondata_lb_port
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/814.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #814
----
commit 8f09e85b013ae692eb2337ae15ce5240d9bb56ed
Author: Mark S. Maglana <[email protected]>
Date: 2016-06-06T20:02:44Z
Add the ability to specify primary and secondary DNS for a node
This change adds two arguments to the create_node() method of the
dimensiondata driver. These arguments, ex_primary_dns and
ex_secondary_dns, allow the client to set the node's DNS servers
at launch time.
commit f3e5a51a2cd2b1c268ff8188b06c2a891f9461a6
Author: Mark S. Maglana <[email protected]>
Date: 2016-06-16T04:47:47Z
Allow setting of load balancer port to None
The documentation for the Dimension Data Cloud REST API v2.2-20160222
states that a load balancer port can be an integer in the range of
1-65535 and, if not supplied, will be taken to mean 'Any Port'
This change fixes the libcloud driver to conform to the docs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
