GitHub user relaxdiego opened a pull request:

    https://github.com/apache/libcloud/pull/818

    Indicate listener ip

    ### Description
    
    This is a replacement of PR #815 
    
    The documentation for the Dimension Data Cloud REST API v2.2-20160222 
states that a load balancer can be statically assigned a listener IP on 
creation. This change fixes the dimension data driver to conform to the docs.
    
    Note that one of the commits (sha f06464a) is part of PR #817 
    
    ### Status
    
    Replace this: describe the PR status. Examples:
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/relaxdiego/libcloud indicate_listener_ip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #818
    
----
commit f06464ac26f7d6ec0fd380e58d5d80229b0d41f7
Author: Mark S. Maglana <[email protected]>
Date:   2016-06-17T16:23:59Z

    Allow setting of load balancer port to None
    
    The documentation for the Dimension Data Cloud REST API v2.2-20160222
    states that a load balancer port can be an integer in the range of
    1-65535 and, if not supplied, will be taken to mean 'Any Port'. This
    change fixes the libcloud driver to conform to the docs.

commit aa1a4664fb5dcd9f566904cdf7dac0b901644d4b
Author: Mark S. Maglana <[email protected]>
Date:   2016-06-16T08:21:50Z

    Allow setting of load balancer listener IP
    
    The documentation for the Dimension Data Cloud REST API v2.2-20160222
    states that a load balancer can be statically assigned a listener IP
    on creation. This change fixes the dimension data driver to conform
    to the docs.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to