Kami commented on a change in pull request #1282: Packet driver extensions
URL: https://github.com/apache/libcloud/pull/1282#discussion_r300501093
##########
File path: libcloud/compute/base.py
##########
@@ -447,7 +447,7 @@ class NodeLocation(object):
'US'
"""
- def __init__(self, id, name, country, driver):
+ def __init__(self, id, name, country, driver, extra=None):
Review comment:
This change is breaking GCE driver because it calls parent constructor after
setting ``extra`` attribute on the class instance.
I have a fix locally which I will include when merging those changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services