gvengel commented on a change in pull request #1324: Fix proxy url
URL: https://github.com/apache/libcloud/pull/1324#discussion_r307871379
##########
File path: libcloud/http.py
##########
@@ -102,7 +102,8 @@ def set_http_proxy(self, proxy_url):
self.http_proxy_used = True
self.session.proxies = {
- self.proxy_scheme: proxy_url
+ 'http': proxy_url,
Review comment:
This was definitely broken for me. I tested with various versions of
requests just in case. Perhaps you have other mitigating factors, like setting
the http_proxy and https_proxy environment variables, or only making http
requests and not https, or vice versa?
Anyway, like you say it can't hurt to set both, and the code's been merged,
so yay!
If I have some spare time, I'll looking into writing some integration tests
for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
