toabctl commented on a change in pull request #1467:
URL: https://github.com/apache/libcloud/pull/1467#discussion_r439710896
##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -2862,10 +2862,14 @@ def list_images(self, location=None,
ex_only_active=True):
raise NotImplementedError(
"ex_only_active in list_images is not implemented "
"in the OpenStack_2_NodeDriver")
- response = self.image_connection.request('/v2/images')
images = []
- for image in response.object['images']:
- images.append(self._to_image(image))
+ path = '/v2/images'
+ while path:
Review comment:
The method looks pretty special. I can try to extract the endless loop
detection and reuse that then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
