Kami commented on pull request #1476: URL: https://github.com/apache/libcloud/pull/1476#issuecomment-683429846
@tgn-outscale Thanks for addressing the review feedback. I merged the PR into trunk, but there are still some places which would ideally be improved in the near future: - Try to make more methods comply with the Libcloud standard API (where possible) - this would make it easier for users to switch to this driver (right now it utilizes a lot of non-standard argument names which means Libcloud code which works with other provider drivers won't work with this one). This includes both - the argument the methods take and method return values - e.g. ``create_node()`` should take name, size and image arguments and return ``Node`` instance class (and not a dictionary). Same goes for some other methods. - Need to add some documentation with examples to ``docs/compute/drivers/`` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
