Eis-D-Z commented on pull request #1519: URL: https://github.com/apache/libcloud/pull/1519#issuecomment-725513360
> @Eis-D-Z Since you recently modified pricing code, you might have some feedback / input on this change - [d7ae996](https://github.com/apache/libcloud/commit/d7ae996e509e71a9d148227c9d32613b09d6af59). > > Imo, it's a right change and something we should have done a while ago when `pricing.json` file started growing... > > In theory, if needed, we could also add new module level constant which can be changed by the user (e.g. `libcloud.pricing.CACHE_ALL_PRICING_DATA = True`). I agree as well the file is quite big and is only going to get larger as more clouds are added, or even as AWS expands in this case. I foresee that in the future the file will get so large that the next logical decision will be to split it, so we will have a pricing file for each cloud separately. Caching the data will save significant time for the users who end up invoking the method a lot. Good job guys! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
