Kami opened a new pull request #1631:
URL: https://github.com/apache/libcloud/pull/1631


   This pull request fixes object name prefix based filtering which was 
accidentally broken by the change in #1584.
   
   It was reported by a user 
(https://github.com/apache/libcloud/pull/1584#issuecomment-983712951), that the 
change breaks the behavior.
   
   I confirmed that myself by adding a test case which was failing with changes 
from #1584, but should pass if the behavior was correct - prefix based 
filtering is based on the object name and not on sub-directory names so 
optimization from #1584 is not a good idea (it's true though that in some 
cases, bucket / sub-directory name is part of the object name, but that's an 
implementation detail).
   
   It achieves that by reverting changes from #1584.
   
   Sadly we didn't have good existing tests which would have caught this issue 
early, but I added some regression tests to help us in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to