Kami commented on code in PR #1967:
URL: https://github.com/apache/libcloud/pull/1967#discussion_r1413052187
##########
libcloud/dns/drivers/godaddy.py:
##########
@@ -288,12 +288,13 @@ def get_zone(self, zone_id):
"""
Get a zone (by domain)
- :param zone_id: The domain, not the ID
+ :param zone_id: The domain ID
:type zone_id: ``str``
:rtype: :class:`Zone`
"""
- result = self.connection.request("/v1/domains/%s/" % zone_id).object
+ domain, = [x.domain for x in self.list_zones() if x.id == zone_id]
Review Comment:
This will throw in case no matching items are found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
