Sanjays2402 opened a new pull request, #2177: URL: https://github.com/apache/libcloud/pull/2177
Closes #1831 ## Route53: fix deleting records which are part of a multi value record set ### Description `delete_record` built a DELETE changeset containing only the value of the record being deleted. Route53 requires a DELETE to list **every** value in the record set, so deleting any record belonging to a multi value set (e.g. one MX value) was rejected as an invalid change batch and surfaced as `RecordDoesNotExistError`. `update_record` already handles this correctly using the `_multi_value` / `_other_records` metadata that `_to_records` attaches to each record. `delete_record` now uses the same metadata and includes the other values of the set in the changeset. The priority prefix that `_to_record` strips out of MX/SRV values is restored so the emitted values match what Route53 stores. Verified against the existing `list_records` fixture: before the change the DELETE changeset for the 5-value MX set contained only `1 ASPMX.L.GOOGLE.COM.`; after it contains all five values. This change was prepared with AI assistance; the regression test was run locally and fails without the fix. ### Status done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
