nightcityblade opened a new pull request, #2181:
URL: https://github.com/apache/libcloud/pull/2181

   ## Fix Azure Blob SAS signatures for encoded object paths
   
   ### Description
   
   Azure Blob SAS canonical resources must use the decoded object path when the
   signature is calculated, while the returned URL must remain percent-encoded.
   Decode the path only for the string-to-sign and add regression coverage for 
an
   object name containing a space.
   
   Fixes #1805.
   
   For more information on contributing, please see 
[Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
   section of our documentation.
   
   ### Status
   
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (`black --check`, `isort --check-only`, and focused `flake8` passed)
   - [ ] Documentation — N/A; this corrects existing signed-URL behavior 
without changing the public API
   - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) 
(`pytest -q libcloud/test/storage/test_azure_blobs.py`: 86 passed)
   - [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 — N/A; this is a focused two-file bug fix
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to