micafer commented on code in PR #2171:
URL: https://github.com/apache/libcloud/pull/2171#discussion_r3911448046
##########
libcloud/test/test_connection.py:
##########
@@ -161,6 +161,18 @@ def test_constructor(self):
{"http": "https://127.0.0.6:3129";, "https":
"https://127.0.0.6:3129"},
)
+ def test_proxy_is_bypassed_for_no_proxy_hosts(self):
+ # Regression test for GITHUB-2077: an explicitly configured proxy must
+ # not be used for hosts listed in the no_proxy environment variable.
+ os.environ["no_proxy"] = "internal.example.com"
+ self.addCleanup(os.environ.pop, "no_proxy", None)
Review Comment:
Hi @Sanjays2402, could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
