fluffynuts commented on a change in pull request #69: URL: https://github.com/apache/logging-log4net/pull/69#discussion_r496985080
########## File path: src/log4net/Core/LoggingEvent.cs ########## @@ -895,7 +895,7 @@ public string UserName { if (m_data.UserName == null && this.m_cacheUpdatable) { -#if (NETCF || SSCLI || NETSTANDARD1_3) // NETSTANDARD1_3 TODO requires platform-specific code +#if (NETCF || SSCLI || NETSTANDARD) // NETSTANDARD TODO requires platform-specific code Review comment: win32 is a valid target for netstandard too -- surely there's a better alternative? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org