ams-tschoening commented on a change in pull request #53:
URL: https://github.com/apache/logging-log4cxx/pull/53#discussion_r583546475
##########
File path: src/main/cpp/domconfigurator.cpp
##########
@@ -331,10 +321,12 @@ void DOMConfigurator::parseErrorHandler(Pool& p,
AppenderMap& appenders)
{
- ErrorHandlerPtr eh = OptionConverter::instantiateByClassName(
+ ErrorHandlerPtr eh;
+ std::shared_ptr<Object> obj = OptionConverter::instantiateByClassName(
Review comment:
There are multiple places using `std::shared_ptr` like above, shouldn't
that be `log4cxx::` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
