[ 
https://issues.apache.org/jira/browse/LOG4J2-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480149#comment-17480149
 ] 

Ralph Goers commented on LOG4J2-3356:
-------------------------------------

[~vy] What he posts above does indeed look wrong. I took a look at the Flume 
module and it has

 
{code:java}
<instructions>
  <Fragment-Host>org.apache.logging.log4j.core</Fragment-Host>
  <Bundle-SymbolicName>org.apache.logging.log4j.flume</Bundle-SymbolicName>
  <Export-Package>org.apache.logging.log4j.flume.appender</Export-Package>
</instructions> {code}
I suspect that Json Template Layout should be using that same Fragment-Host, 
the bundle name should match the actual component, and export package should 
specify what you actually want public instead of everything.

> The sub module log4j-layout-template-json seems not properly configured to be 
> deployed as a fragment host in OSGI
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-3356
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-3356
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: JsonTemplateLayout
>    Affects Versions: 2.17.1
>         Environment: Tested on ServiceMix (under Docker) 7.0.1, but it should 
> be the same in Karaf 4.x
> I also tried to add the original log4j2-api and log4j-core in the same config 
> but the fragment never gets resolved.
>            Reporter: ruffp
>            Priority: Major
>
> In the 
> [pom|https://github.com/apache/logging-log4j2/blob/release-2.x/log4j-layout-template-json/pom.xml]
>  of the module we have:
> {code:xml}
> <plugin>
>         <groupId>org.apache.felix</groupId>
>         <artifactId>maven-bundle-plugin</artifactId>
>         <configuration>
>           <instructions>
>             
> <Fragment-Host>org.apache.logging.log4j.layout.template.json</Fragment-Host>
>             <Export-Package>*</Export-Package>
>           </instructions>
>         </configuration>
>       </plugin>
> {code}
> The Fragment host seems to refer to itself.
> When I tried to deploy this jar as a bundle with this in my 
> startup.properties file: 
> {noformat}
> mvn\:org.apache.logging.log4j/log4j-layout-template-json/2.17.1 = 5
> mvn\:org.ops4j.pax.logging/pax-logging-log4j2-extra/1.11.13 = 6
> mvn\:org.ops4j.pax.logging/pax-logging-api/1.11.13 = 8
> mvn\:org.ops4j.pax.logging/pax-logging-log4j2/1.11.13 = 8
> {noformat}
> And copying the lib in the "system" folder of karaf (I tried with ServiceMix 
> 7.0.1).
> The bundle stays in status "Installed" and never resolves as the 
> Fragment-Host refers to itself.
> I am not sure what values should be set in this as I am using Pax Logging, 
> but for sure the Host does not seems correct to me (otherwise I would have 
> created a PR).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to