garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819962777



##########
File path: 
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##########
@@ -30,4 +40,22 @@ public void testJira_LOG4J2_2770_byteArray() throws 
Exception {
         ConfigurationSource configurationSource = new ConfigurationSource(new 
ByteArrayInputStream(new byte[] { 'a', 'b' }));
         assertNotNull(configurationSource.resetInputStream());
     }
+
+    @Test
+    @EnabledOnOs({OS.LINUX, OS.AIX, OS.MAC, OS.SOLARIS})

Review comment:
       Also I think we should keep prefixing test methods with "test" which 
makes it simpler to recognize in an IDE's method list view.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to