HannesWell commented on code in PR #1820:
URL: https://github.com/apache/logging-log4j2/pull/1820#discussion_r1340132628
##########
log4j-to-slf4j/pom.xml:
##########
@@ -89,19 +89,5 @@
<scope>test</scope>
</dependency>
</dependencies>
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <configuration>
- <instructions>
-
<Bundle-Activator>org.apache.logging.slf4j.Activator</Bundle-Activator>
- <Export-Package>org.apache.logging.slf4j</Export-Package>
-
<Import-Package>org.slf4j*;version="${range;[==,${slf4j.support.bound})}",*</Import-Package>
Review Comment:
Sounds fine.
If you reach that module it is maybe sufficient to just add another
`bnd`-configuration element for the bnd-maven-plugin with (CDATA) content like:
`Import-Package: org.slf4j*;version="${range;[==,${slf4j.support.bound})}",*`
This should overwrite the configuration from the parent:
https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-maven-plugin#bnd-instruction-inheritance
And regarding other headers,
https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-maven-plugin#reproducible-builds
might be interesting as well (all just in case you didn't know that already
#1142 ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
