ppkarwasz commented on code in PR #3450:
URL: https://github.com/apache/logging-log4j2/pull/3450#discussion_r1995255964
##########
log4j-parent/pom.xml:
##########
@@ -154,6 +154,15 @@
<httpcore.version>4.4.16</httpcore.version>
<jna.version>5.16.0</jna.version>
+ <!-- Add 'requires static' for annotation library dependencies (defined as
<scope>provided</scope> in this file)
+ to allow them to be visible at compile time to make the
'-Xlint:classfile' check of javac pass.
+ Overrides parent's 'bnd-jpms-module-info' and hence re-defines
'$[bnd-module-name];access=0' -->
+ <bnd-jpms-module-info>$[bnd-module-name];access=0;modules="
+ biz.aQute.bnd.annotation,
+ com.google.errorprone.annotations,
+ com.github.spotbugs.annotations,
+ org.osgi.annotation.bundle
Review Comment:
Can you add `org.osgi.annotation.versioning` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
