ramanathan1504 commented on PR #3926: URL: https://github.com/apache/logging-log4j2/pull/3926#issuecomment-4291128870
Hi @vy, Apologies for the long delay in getting back to this. I have been reviewing the requirements and I would like to proceed with the revamp of `ListAppender` as you suggested. My plan is to: 1. **Establish complete thread-safety** using method-level synchronization (and removing the current mix of `volatile`/`synchronizedList`). 2. **Ensure `append()` captures `toImmutable()` events** to support garbage-free logging. 3. **Update the Javadocs** for the class and the `countDownLatch` functionality. 4. **Clean up the code** (apply diamond operators, final fields, and other IDE suggestions). 5. **Add comprehensive tests**, including a concurrency suite. You mentioned having a **simple recipe for testing the thread safety**—could you please share that? I want to make sure the test suite meets your expectations. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
