jmestwa-coder opened a new pull request, #635: URL: https://github.com/apache/logging-log4cxx/pull/635
## Summary Refactor `StringHelper::equalsIgnoreCase` to use explicit length-bounded comparison instead of pointer traversal. --- ## What changed * Use `std::char_traits<logchar>::length(upper)` to determine length * Check `s1.length()` before comparison * Replace pointer increments with index-based access * Preserve embedded NUL handling --- ## Why * Removes implicit pointer traversal * Makes bounds explicit and easier to reason about * Keeps behavior unchanged --- ## Behavior No behavior change intended. --- ## Testing Added tests for: * case-insensitive match * length mismatch * embedded NUL All tests pass. --- ## Notes All current call sites pass paired uppercase/lowercase literals of identical length, which this change relies on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
