vy commented on issue #4105: URL: https://github.com/apache/logging-log4j2/issues/4105#issuecomment-4338870798
> * `AnsiEscape` does not have the `ITALIC` entry. > * `AnsiEscape.UNDERLINE` has the code value of `3` which correspond to `ITALIC`. > * Code value `4` which corresponds to `underline` style seems to not be assigned to any enum value in `AnsiEscape`. @raphaelNguyen, thanks so much for the report and the through analysis. @ppkarwasz was the main figure behind the #3070 improvement, but AFAICS: Removed `JAnsiTextRenderer::toCode` was using `org.fusesource.jansi.AnsiRenderer.Code`: https://github.com/apache/logging-log4j2/pull/3070/changes#diff-17d0910e25d63f1dbdae9e77b69133454db40f1db1922485863bfbe43c937697L341-L343 `Code` enum gets the codes from `org.fusesource.jansi.Ansi.Attribute`: https://github.com/fusesource/jansi/blob/c10d43f48cfdd80ba14dc78b194bc5449f23236d/src/main/java/org/fusesource/jansi/AnsiRenderer.java#L207 And there `ITALIC` and `UNDERLINE` exist: https://github.com/fusesource/jansi/blob/c10d43f48cfdd80ba14dc78b194bc5449f23236d/src/main/java/org/fusesource/jansi/Ansi.java#L89 I suspect `AnsiEscape` needs to updated to include `ITALIC`, get the code for `UNDERLINE` fixed, and checked for other differences. @raphaelNguyen, would you be interested in contributing this fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
