ppkarwasz commented on code in PR #467:
URL: https://github.com/apache/logging-parent/pull/467#discussion_r3167440766
##########
.asf.yaml:
##########
@@ -68,37 +68,36 @@ github:
features:
issues: true
- # Clear Protected Branches configuration: it is replaced by GitHub Rulesets
- protected_branches: { }
+ protected_branches:
Review Comment:
Please don't: if I interpret the code in
[infrastructure-asfyaml](https://github.com/apache/infrastructure-asfyaml)
correctly, all you'll end up doing is to introduce Brach Protection **on top*
of Branch Rulesets.
There is no code to remove `rulesets` if the tag is there and anyway the
code to remove a ruleset is currently not working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
