ramanathan1504 opened a new pull request, #4116:
URL: https://github.com/apache/logging-log4j2/pull/4116
Fixes #3505 Issue #2791
Addressed review feedback in this update:
1. Properties builder robustness
(`log4j-core/.../PropertiesConfigurationBuilder.java`)
- Added explicit guard for missing `rootProperties` in `build()`.
- Replaced direct `Long.parseLong(...)` for `shutdownTimeout` with
validated parsing (`parseShutdownTimeout(...)`) that throws a
`ConfigurationException` with a clear message.
- Kept builder API usage compatible with current interfaces
(`setLevelAttribute(...)`, `setAdditivityAttribute(...)`) to avoid regressions.
2. Properties consumption correctness
(`log4j-core/.../PropertiesConfigurationBuilder.java`)
- Switched logger/root `levelAndRefs` reads to remove the consumed key
(`properties.remove("")`) to avoid stale/unprocessed entries.
- Ensured remaining logger/root properties are processed via
`processRemainingProperties(...)` before returning, so extra nested
attributes/components are not dropped.
3. Null/empty check cleanup
(`log4j-core/.../PropertiesConfigurationBuilder.java`)
- Simplified redundant null-or-empty check to `Strings.isEmpty(type)` in
`createComponent(...)`.
4. Changelog typo fix
(`src/changelog/.2.x.x/2791_rework_ComponentBuilder_API.xml`)
- Corrected `JVerify` -> `JSpecify`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
