ppkarwasz commented on code in PR #4120:
URL: https://github.com/apache/logging-log4j2/pull/4120#discussion_r3214409210
##########
.github/dependabot.yaml:
##########
@@ -188,6 +197,15 @@ updates:
# see https://github.com/apache/logging-log4j2/issues/1736
- dependency-name: "org.fusesource.jansi:jansi"
update-types: [ "version-update:semver-major" ]
+ # Keep JUnit below 6.x: JUnit 6+ requires Java 17 and breaks Java 8 test
runs
+ - dependency-name: "org.junit:junit-bom"
+ versions: [ "[6,)" ]
+ - dependency-name: "org.junit.jupiter:*"
+ versions: [ "[6,)" ]
+ - dependency-name: "org.junit.platform:*"
+ versions: [ "[6,)" ]
+ - dependency-name: "org.junit.vintage:*"
+ versions: [ "[6,)" ]
Review Comment:
The `main` branch has a baseline of Java 17; I wouldn't limit the version of
JUnit in this case and only do it for `2.x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
