DrDrunkenstien-10 commented on PR #4103: URL: https://github.com/apache/logging-log4j2/pull/4103#issuecomment-4428138043
@ppkarwasz Updated the PR to validate invalid SD-ID and MSGID inputs, renamed `id` to `sdId` and `type` to `msgId` in both the code and Javadocs, and updated the Javadocs to mention that `StructuredDataId` is recommended because it allows specifying allowed keys. I did not implement enforcement of the allowed keys defined by `StructuredDataId`, since that appears to be a separate behavioral issue and may be better addressed in its own PR. I'm happy to include that change in this PR as well if you would prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
