swebb2066 commented on PR #658: URL: https://github.com/apache/logging-log4cxx/pull/658#issuecomment-4447784311
I think moving the duplicated `isWide()` implementations to a single implementation in `consolewrite.cpp` would improve the code. Note that both implementations are currently `private`, so can be removed from the class interface without breaking the ABI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
