omribz156 commented on code in PR #480: URL: https://github.com/apache/logging-parent/pull/480#discussion_r3537665155
########## src/site/antora/modules/ROOT/pages/release-instructions-project.adoc: ########## @@ -89,6 +90,7 @@ You can iterate on the `release/7.8.0` branch to perfect it. .. *Signed artifacts* are uploaded to the _Staging Repositories_ in https://repository.apache.org/[repository.apache.org] .. *Signed distribution and its checksum* (e.g., `apache-{project-id}-7.8.0-{bin,src}.{zip,.zip.asc,.zip.sha512}`) are uploaded to https://dist.apache.org/repos/dist/dev/logging/{project-id}[dist.apache.org/repos/dist/**dev**/logging/{project-id}/7.8.0] Subversion repository (along with auxiliary files; website, email texts, etc.) .. {site-url-staging}-7.8.0[The release staging website] is deployed using the freshly populated `release/7.8.0-site-stg-out` branch +.. Project-specific CI for `release/`-prefixed branches succeeds. Review Comment: Fixed in ec44eef. Removed the redundant project-specific CI check from the release staging verification list. Verified with git diff --check. ########## src/site/antora/modules/ROOT/pages/release-instructions-project.adoc: ########## @@ -154,16 +149,22 @@ git push origin rel/7.8.0 ==== The ASF infrastructure treats ``rel/``-prefixed git tags special and ensures they are immutable for provenance reasons. ==== -. Merge the `rel/7.8.0` tag (**not** the `release/7.8.0` branch!) to `main` +. Create a branch from `main`, merge the `rel/7.8.0` tag (**not** the `release/7.8.0` branch!), and push it Review Comment: Fixed in ec44eef. Updated the step to say to create a PR from the branch after merging the rel/7.8.0 tag. Verified with git diff --check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
